-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing condition for retrieving data on the provider topology pages #3214
Conversation
@skateman unrecognized command 'add', ignoring... Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone |
26a52ca
to
a25d06b
Compare
a25d06b
to
fe7ae03
Compare
Checked commit skateman@fe7ae03 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
LGTM, matches what used to happen before (https://github.com/ManageIQ/manageiq-ui-classic/pull/3087/files#diff-ae0b2046e6aacd6b9890ae1d5b1648a4L27), merging when green... |
Cloud, infra, container project, and physical server seem to work completely now :) |
OK, Merging when green :) |
Add missing condition for retrieving data on the provider topology pages (cherry picked from commit 769e80d) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1533237
Gaprindashvili backport details:
|
When you go to a provider's (e.g. infra) summary screen and select the topology in the table view, the topology data are not being loaded onto the controller.
The problem was that the condition for building the URL did not cover this way of displaying a topology screen. I updated the condition to make this work, however, some refactoring should be done in the future. The code is too much spaghetti for adding any tests, but after @Hyperkid123 is finished with the refactoring, it should be easy.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1532404